Code review comment for lp:~michael.nelson/charm-helpers/add-declarative-support

Revision history for this message
Michael Nelson (michael.nelson) wrote :

On Thu, Jun 13, 2013 at 1:03 AM, Matthew Wedgwood <
<email address hidden>> wrote:

> Per our discussion in IRC, this looks like a good candidate for
> charmhelpers.contrib.saltstack, rather than to be the more generally-named
> "declarative." This naming will make it clear which config format is in
> play and helps keep the namespace clean for future puppet, chef, etc.
> modules.
>
>
Great - thanks Matthew. I've ended up moving it to
charmhelpers.contrib.saltstates so that it's clearer that we're just using
saltstacks support of local machine states, rather than the full saltstack
support (ie. master+slave). If you'd prefer saltstack, just let me know and
I'll switch it.

« Back to merge proposal