Code review comment for lp:~michael-sheldon/webbrowser-app/ssl-status

Revision history for this message
Olivier Tilloy (osomon) wrote :

> > 285 + target: certificateError ? certificateError : null
> >
> > isn’t this equivalent to:
> >
> > target: certificateError
>
> This would cause a warning due to the certificateError being undefined on
> start up (whereas explicitly setting a null target won't).

Ah, ok. I would have expected it to be 'null' rather than 'undefined'. The conditional makes sense then.

« Back to merge proposal