Code review comment for lp:~michael-sheldon/webbrowser-app/implement-download-folder
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
In Browser.qml, the condition for the enabled-ness of the keyboard shortcuts could be improved by merging the changes in lp:~osomon/webbrowser-app/keyboard-shortcuts-focus-fixes and ensuring that tabContainer is not visible when downloadsContainer is.
Alternatively, if we’re in a rush to land this, I’ll merge back your changes in my branch after it lands, and will fix it there.