Code review comment for lp:~michael-sheldon/webbrowser-app/fix-1531179

Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good to me. A couple of minor suggestions:

  - "id: downloadsLoader" is unnecessary, in onLoaded you can directly refer to item

  - a Loader is a FocusScope, so "downloadsLoader.item.focus = true" should not be needed

In fact for consistency it would be better if the FocusScope with id 'downloadsContainer' was made a Loader (like bookmarksViewLoader, historyViewLoader, and settingsViewLoader).

« Back to merge proposal