Code review comment for lp:~michael-sheldon/webbrowser-app/fix-1354388

Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good, and works as expected. Thanks!

I’m seeing an additional use case that doesn’t seem to be covered (although I don’t think it’s a new regression, so it may be fine to tackle it separately):

  - browse to any page that triggers the display of a certificate warning page (e.g. https://testssl-expire.disig.sk/) and choose to proceed anyway
  - close the browser and open it again, the previously open page is re-loaded
  - the certificate warning page is displayed, but the address bar is empty, until you choose to proceed anyway

If you think it can be addressed easily and with minimal changes to this MR, then go ahead, otherwise I’m happy to report it separately afterwards.

review: Approve

« Back to merge proposal