webbrowser-app

Code review comment for lp:~michael-sheldon/webbrowser-app/file-upload

  1. file-upload
  2. Merge into trunk
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

file:///home/osomon/dev/phablet/browser/webbrowser-app/src/app/ContentPickerDialog.qml:60:17: Unable to assign [undefined] to QObject*

 Should be fixed now.

file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Content/ResponsiveGridView.qml:37: TypeError: Cannot read property 'count' of undefined

 This one appears to have been introduced on the content-hub side when using a custom loader, so I'll fix that in a content-hub MR.

 Displaying messages when no peers are found should probably also happen in the content-hub (the main ContentPeerPicker element comes from content-hub, ContentPickerDialog is just a wrapper around it to make it usable within the browser).

« Back to merge proposal