Code review comment for lp:~michael-sheldon/webbrowser-app/file-upload

Revision history for this message
Olivier Tilloy (osomon) wrote :

Testing on my desktop, and I don’t have any app registered in the content hub, so the picker shows up empty, and I’m seeing the following two errors on the console:

file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Content/ResponsiveGridView.qml:37: TypeError: Cannot read property 'count' of undefined
file:///home/osomon/dev/phablet/browser/webbrowser-app/src/app/ContentPickerDialog.qml:60:17: Unable to assign [undefined] to QObject*

That’s a corner case of course, but it would be nice if it could be handled gracefully (ideally some message to the user, which would be something to discuss with design, but even without that, at least make the code robust enough to not spit out errors when the list of handlers is empty).

« Back to merge proposal