Code review comment for lp:~michael-sheldon/webbrowser-app/file-upload

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/webbrowser-app) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * Added dialog containing a ContentPeerPicker (specified in https://docs.google.com/a/canonical.com/document/d/1trse15NokU8IJ5lm3BnUi7oMNTCkUnYNHeAHZdtzFoQ)

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * Added qtdeclarative5-ubuntu-content0.1 to dependencies, subscribed: ken-vandine

« Back to merge proposal