content-hub

Merge lp:~michael-sheldon/content-hub/responsivegridview into lp:content-hub

  1. responsivegridview
  2. Merge into trunk
Proposed by Michael Sheldon
Status: Merged
Approved by: Ken VanDine
Approved revision: 99
Merged at revision: 100
Proposed branch: lp:~michael-sheldon/content-hub/responsivegridview
Merge into: lp:content-hub
Diff against target: 11 lines (+0/-2)
1 file modified
import/Ubuntu/Content/ResponsiveGridView.qml (+0/-2)
To merge this branch: bzr merge lp:~michael-sheldon/content-hub/responsivegridview
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+220476@code.launchpad.net

Commit message

Remove aliases for GridView properties that no longer exist.

Description of the change

Removes aliases for GridView properties that no longer exist.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:99
http://jenkins.qa.ubuntu.com/job/content-hub-ci/149/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-utopic-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-utopic-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-utopic-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-utopic-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/content-hub-ci/149/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No, but lp:~ken-vandine/content-hub/abi-fix is required for ABI compatibility with existing apps

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * No change

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good, tested on mako.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'import/Ubuntu/Content/ResponsiveGridView.qml'
--- import/Ubuntu/Content/ResponsiveGridView.qml 2014-04-08 20:21:31 +0000
+++ import/Ubuntu/Content/ResponsiveGridView.qml 2014-05-21 14:39:29 +0000
@@ -37,8 +37,6 @@
37 readonly property alias flicking: gridView.flicking37 readonly property alias flicking: gridView.flicking
38 readonly property alias moving: gridView.moving38 readonly property alias moving: gridView.moving
39 readonly property alias pressDelay: gridView.pressDelay39 readonly property alias pressDelay: gridView.pressDelay
40 property alias delegateCreationBegin: gridView.delegateCreationBegin
41 property alias delegateCreationEnd: gridView.delegateCreationEnd
42 property alias highlightIndex: gridView.highlightIndex40 property alias highlightIndex: gridView.highlightIndex
43 readonly property alias currentItem: gridView.currentItem41 readonly property alias currentItem: gridView.currentItem
4442

Subscribers

People subscribed via source and target branches