Merge lp:~michael-sheldon/content-hub/responsivegridview into lp:content-hub

Proposed by Michael Sheldon
Status: Merged
Approved by: Ken VanDine
Approved revision: 99
Merged at revision: 100
Proposed branch: lp:~michael-sheldon/content-hub/responsivegridview
Merge into: lp:content-hub
Diff against target: 11 lines (+0/-2)
1 file modified
import/Ubuntu/Content/ResponsiveGridView.qml (+0/-2)
To merge this branch: bzr merge lp:~michael-sheldon/content-hub/responsivegridview
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+220476@code.launchpad.net

Commit message

Remove aliases for GridView properties that no longer exist.

Description of the change

Removes aliases for GridView properties that no longer exist.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No, but lp:~ken-vandine/content-hub/abi-fix is required for ABI compatibility with existing apps

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * No change

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good, tested on mako.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'import/Ubuntu/Content/ResponsiveGridView.qml'
2--- import/Ubuntu/Content/ResponsiveGridView.qml 2014-04-08 20:21:31 +0000
3+++ import/Ubuntu/Content/ResponsiveGridView.qml 2014-05-21 14:39:29 +0000
4@@ -37,8 +37,6 @@
5 readonly property alias flicking: gridView.flicking
6 readonly property alias moving: gridView.moving
7 readonly property alias pressDelay: gridView.pressDelay
8- property alias delegateCreationBegin: gridView.delegateCreationBegin
9- property alias delegateCreationEnd: gridView.delegateCreationEnd
10 property alias highlightIndex: gridView.highlightIndex
11 readonly property alias currentItem: gridView.currentItem
12

Subscribers

People subscribed via source and target branches