Code review comment for lp:~michael-abbott/epics-base/dynamic-array
Revision history for this message
| Michael Abbott (michael-abbott) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Well, I've responded to Jeff's review comments.
* I've updated the version number and guard from 4.12 to 4.13. Of course, this means that this branch really does need to be merged after the TCP-based search requests feature.
* Rather than think very hard (and maybe make a stupid mistake) I've just guarded the memset() that Jeff flagged with the obvious sanity test.
* I've re-merged with EPICS base. As I noted on the mailing list, this introduced a massive merge conflict with the variable renaming in db_access.c, but as the renaming is quite gratuitous I simply dropped that part of the merge.
* I'm sorry, I've not done anything to acctst.c. As far as I can see it's client side only, and I don't really see where to get started without spending a *lot* of time on it. I'll try and look at this again another time.