Code review comment for lp:~mhr3/unity8/use-dee-filtermodel

Michal Hruby (mhr3) wrote :

> Regarding the tests:
>
> So this merge updates the mocks for the existing qml UI tests (very poorly
> tested btw) which is good.
>
> However, the new code itself is not tested. I guess the reason is because the
> surrounding and replaced code does not have tests either. Do you think we
> could add some in this merge or better having another TODO to test the whole
> scopes+category stuff?

This involves communication with real scopes, so ideally it should talk to real scopes, which means autopilot tests would be ideal. There are multiple branches landing these days that will allow full usage of scopes including activation and previewing, once we have all this and some actual scopes that the device will be running, we should add tests for all these aspects.

« Back to merge proposal