Code review comment for lp:~mhr3/unity-scopes-api/always-join-threads

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

This is cool, although, why not encapsulate completely and make this an actual class with private members and public methods. You could just add a "core::posix::ChildProcess::DeathObserver& death_observer()" method for use in the RegistryObject constructor.

Then, while you're at it, could you please update scoperunner and smartscopesproxy with the same fix. Thanks :)

review: Needs Fixing

« Back to merge proposal