Code review comment for lp:~mhr3/unity-lens-music/home-lenses

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

There appears to be a merge conflict?

While you resolve it you might want to look at this nitpick:

102 + var iter = helper_model.get_first_iter ();
103 + while (iter != helper_model.get_last_iter ())

I usually add a helper variable 'var end = helper_model.get_last_iter ()' and do 'while (iter != end)'. This saves quite a bit of type checking.

review: Needs Fixing

« Back to merge proposal