Code review comment for lp:~mhr3/libzeitgeist/symbols
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Fixed 2) 3) 4) 5).
As for 1) I'm not inclined to make it take ownership, because it's taking GStrv, and therefore it'd suggest to free the data using g_strfreev(), but I pass static strings, so they don't need freeing. Also the SymbolInfo doesn't directly use the strings, it creates quarks from them.