Code review comment for lp:~mhr3/libunity/remote-scope-sources

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

68 - public OptionsFilter sources { get; internal set; }
69 + public OptionsFilter sources { get; private set; }

Technicaly this is an ABI break. Although only in internal ABI. If it's just a cleanup I suggest we leave it as is to not trigger the alarm bells of the packaging system.

$ nm -D src/.libs/libunity.so | grep set_sources
0001d931 T unity_lens_set_sources_display_name
000483ac T unity_scope_proxy_set_sources
$ nm -D /usr/lib/libunity.so | grep set_sources
00017140 T unity_lens_set_sources_display_name
00037c80 T unity_scope_proxy_set_sources
0002d350 T unity_scope_set_sources

review: Needs Fixing

« Back to merge proposal