Merge lp:~mhr3/libunity/filter-state-update into lp:~unity-team/libunity/libunity-7.0

Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 375
Merged at revision: 374
Proposed branch: lp:~mhr3/libunity/filter-state-update
Merge into: lp:~unity-team/libunity/libunity-7.0
Diff against target: 56 lines (+15/-2)
3 files modified
debian/libunity9.symbols (+1/-0)
src/unity-aggregator-scope-private.vala (+5/-0)
src/unity-scope-channel.vala (+9/-2)
To merge this branch: bzr merge lp:~mhr3/libunity/filter-state-update
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+161944@code.launchpad.net

Commit message

Update filter state for all channels after a change.

Description of the change

Update filter state for all channels after a change.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
375. By Michal Hruby

Update symbols

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM and works fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/libunity9.symbols'
--- debian/libunity9.symbols 2013-04-25 16:05:20 +0000
+++ debian/libunity9.symbols 2013-05-01 21:13:26 +0000
@@ -378,6 +378,7 @@
378 unity_internal_scope_channel_is_search_running@Base 0replaceme378 unity_internal_scope_channel_is_search_running@Base 0replaceme
379 unity_internal_scope_channel_new@Base 6.91.9daily13.04.10ubuntu.unity.experimental.certified379 unity_internal_scope_channel_new@Base 6.91.9daily13.04.10ubuntu.unity.experimental.certified
380 unity_internal_scope_channel_register_pushed_model@Base 0replaceme380 unity_internal_scope_channel_register_pushed_model@Base 0replaceme
381 unity_internal_scope_channel_set_filter_base@Base 0replaceme
381 unity_internal_scope_channel_new@Base 0replaceme382 unity_internal_scope_channel_new@Base 0replaceme
382 unity_internal_scope_channel_set_state@Base 0replaceme383 unity_internal_scope_channel_set_state@Base 0replaceme
383 unity_internal_scope_channel_wait_for_search@Base 0replaceme384 unity_internal_scope_channel_wait_for_search@Base 0replaceme
384385
=== modified file 'src/unity-aggregator-scope-private.vala'
--- src/unity-aggregator-scope-private.vala 2013-04-30 15:58:10 +0000
+++ src/unity-aggregator-scope-private.vala 2013-05-01 21:13:26 +0000
@@ -993,6 +993,11 @@
993 queue_property_notification ("Filters",993 queue_property_notification ("Filters",
994 new Variant.variant (this.filters));994 new Variant.variant (this.filters));
995 }995 }
996
997 foreach (var channel in _channels.get_values ())
998 {
999 channel.set_filter_base (filters_model);
1000 }
996 }1001 }
9971002
998 private void on_proxy_results_invalidated (ChannelType channel_type)1003 private void on_proxy_results_invalidated (ChannelType channel_type)
9991004
=== modified file 'src/unity-scope-channel.vala'
--- src/unity-scope-channel.vala 2013-04-30 15:58:10 +0000
+++ src/unity-scope-channel.vala 2013-05-01 21:13:26 +0000
@@ -152,6 +152,15 @@
152 backend_model.set_column_names_full (RESULTS_COLUMN_NAMES);152 backend_model.set_column_names_full (RESULTS_COLUMN_NAMES);
153 backend_model.register_vardict_schema (METADATA_COLUMN, vardict_schema);153 backend_model.register_vardict_schema (METADATA_COLUMN, vardict_schema);
154154
155 set_filter_base (filter_model);
156
157 return swarm_name;
158 }
159
160 public void set_filter_base (Dee.SerializableModel filter_model)
161 {
162 filters = new FilterSet ();
163
155 // make a copy of filter_model, and handle the filter state there164 // make a copy of filter_model, and handle the filter state there
156 var fm_iter = filter_model.get_first_iter ();165 var fm_iter = filter_model.get_first_iter ();
157 var end_iter = filter_model.get_last_iter ();166 var end_iter = filter_model.get_last_iter ();
@@ -161,8 +170,6 @@
161 if (filter != null) filters.add (filter);170 if (filter != null) filters.add (filter);
162 fm_iter = filter_model.next (fm_iter);171 fm_iter = filter_model.next (fm_iter);
163 }172 }
164
165 return swarm_name;
166 }173 }
167174
168 public unowned Filter? get_filter_by_id (string filter_id)175 public unowned Filter? get_filter_by_id (string filter_id)

Subscribers

People subscribed via source and target branches

to all changes: