Code review comment for lp:~mhr3/libunity/api-tweaks

Revision history for this message
Michal Hruby (mhr3) wrote :

> Looks good overall, just two comments:
>
> 86 + if (o.get_type ().name ().has_prefix ("Unity"))
>
> This check looks a bit shaky, but I recon we can't do much more... So, how
> about renaming object_unref to unity_object_unref to emphasize this
> requirement?

That's already the name, note the Unity namespace.

>
> 82 + public static void object_unref (void* object)
> What's the use case / who is going to use it? Can you add a docstring?

It's *the* destructor for everything.

« Back to merge proposal