Code review comment for lp:~mhr3/libunity/api-tweaks

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good overall, just two comments:

86 + if (o.get_type ().name ().has_prefix ("Unity"))

This check looks a bit shaky, but I recon we can't do much more... So, how about renaming object_unref to unity_object_unref to emphasize this requirement?

82 + public static void object_unref (void* object)
What's the use case / who is going to use it? Can you add a docstring?

review: Needs Fixing

« Back to merge proposal