Merge lp:~mhr3/libappindicator/vala-bindings-fix into lp:libappindicator

Proposed by Michal Hruby
Status: Merged
Merged at revision: 215
Proposed branch: lp:~mhr3/libappindicator/vala-bindings-fix
Merge into: lp:libappindicator
Diff against target: 76 lines (+35/-2)
4 files modified
bindings/vala/Makefile.am (+2/-1)
bindings/vala/appindicator-0.1-custom.vala (+31/-0)
bindings/vala/examples/indicator-example.vala (+1/-0)
configure.ac (+1/-1)
To merge this branch: bzr merge lp:~mhr3/libappindicator/vala-bindings-fix
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+76765@code.launchpad.net

Commit message

Fixes type checking for Vala, bumped valac requirement (older vapigen cant handle gir properly)

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bindings/vala/Makefile.am'
--- bindings/vala/Makefile.am 2011-02-04 00:48:02 +0000
+++ bindings/vala/Makefile.am 2011-09-23 15:49:53 +0000
@@ -25,9 +25,10 @@
2525
26$(vapiprefix).vapi: $(top_builddir)/src/AppIndicator$(VER)-0.1.gir \26$(vapiprefix).vapi: $(top_builddir)/src/AppIndicator$(VER)-0.1.gir \
27 $(top_builddir)/src/AppIndicator$(VER)-0.1.metadata \27 $(top_builddir)/src/AppIndicator$(VER)-0.1.metadata \
28 $(vapiprefix)-custom.vala \
28 $(vapiprefix).deps29 $(vapiprefix).deps
29 $(VALA_API_GEN) --library=$(vapiprefix) --girdir=$(srcdir)/src \30 $(VALA_API_GEN) --library=$(vapiprefix) --girdir=$(srcdir)/src \
30 $<31 $< $(vapiprefix)-custom.vala
31 32
3233
33CLEANFILES = $(vapi_DATA)34CLEANFILES = $(vapi_DATA)
3435
=== added file 'bindings/vala/appindicator-0.1-custom.vala'
--- bindings/vala/appindicator-0.1-custom.vala 1970-01-01 00:00:00 +0000
+++ bindings/vala/appindicator-0.1-custom.vala 2011-09-23 15:49:53 +0000
@@ -0,0 +1,31 @@
1/*
2 Copyright (C) 2011 Canonical, Ltd.
3
4 This program is free software: you can redistribute it and/or modify it
5 under the terms of either or both of the following licenses:
6
7 1) the GNU Lesser General Public License version 3, as published by the
8 Free Software Foundation; and/or
9 2) the GNU Lesser General Public License version 2.1, as published by
10 the Free Software Foundation.
11
12 This program is distributed in the hope that it will be useful, but
13 WITHOUT ANY WARRANTY; without even the implied warranties of
14 MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR
15 PURPOSE. See the applicable version of the GNU Lesser General Public
16 License for more details.
17
18 You should have received a copy of both the GNU Lesser General Public
19 License version 3 and version 2.1 along with this program. If not, see
20 <http://www.gnu.org/licenses/>
21
22 Authored by Michal Hruby <michal.hruby@canonical.com>
23*/
24
25namespace AppIndicator {
26 [CCode (type_check_function = "IS_APP_INDICATOR")]
27 public class Indicator : GLib.Object {
28 }
29}
30
31// vim:et:ai:cindent:ts=2 sts=2 sw=2:
032
=== modified file 'bindings/vala/examples/indicator-example.vala'
--- bindings/vala/examples/indicator-example.vala 2011-07-20 01:20:54 +0000
+++ bindings/vala/examples/indicator-example.vala 2011-09-23 15:49:53 +0000
@@ -34,6 +34,7 @@
3434
35 var indicator = new Indicator(win.title, "indicator-messages",35 var indicator = new Indicator(win.title, "indicator-messages",
36 IndicatorCategory.APPLICATION_STATUS);36 IndicatorCategory.APPLICATION_STATUS);
37 if (!(indicator is Indicator)) return -1;
3738
38 indicator.set_status(IndicatorStatus.ACTIVE);39 indicator.set_status(IndicatorStatus.ACTIVE);
39 indicator.set_attention_icon("indicator-messages-new");40 indicator.set_attention_icon("indicator-messages-new");
4041
=== modified file 'configure.ac'
--- configure.ac 2011-08-11 16:58:08 +0000
+++ configure.ac 2011-09-23 15:49:53 +0000
@@ -97,7 +97,7 @@
97# Vala Compiler support97# Vala Compiler support
98###########################98###########################
9999
100AM_PROG_VALAC([0.11.0])100AM_PROG_VALAC([0.14.0])
101AM_CONDITIONAL(HAVE_VALAC, [test "x$VALAC" != "x"])101AM_CONDITIONAL(HAVE_VALAC, [test "x$VALAC" != "x"])
102102
103###########################103###########################

Subscribers

People subscribed via source and target branches