Merge lp:~mhr3/libappindicator/vala-bindings-fix into lp:libappindicator

Proposed by Michal Hruby
Status: Merged
Merged at revision: 215
Proposed branch: lp:~mhr3/libappindicator/vala-bindings-fix
Merge into: lp:libappindicator
Diff against target: 76 lines (+35/-2)
4 files modified
bindings/vala/Makefile.am (+2/-1)
bindings/vala/appindicator-0.1-custom.vala (+31/-0)
bindings/vala/examples/indicator-example.vala (+1/-0)
configure.ac (+1/-1)
To merge this branch: bzr merge lp:~mhr3/libappindicator/vala-bindings-fix
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+76765@code.launchpad.net

Commit message

Fixes type checking for Vala, bumped valac requirement (older vapigen cant handle gir properly)

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bindings/vala/Makefile.am'
2--- bindings/vala/Makefile.am 2011-02-04 00:48:02 +0000
3+++ bindings/vala/Makefile.am 2011-09-23 15:49:53 +0000
4@@ -25,9 +25,10 @@
5
6 $(vapiprefix).vapi: $(top_builddir)/src/AppIndicator$(VER)-0.1.gir \
7 $(top_builddir)/src/AppIndicator$(VER)-0.1.metadata \
8+ $(vapiprefix)-custom.vala \
9 $(vapiprefix).deps
10 $(VALA_API_GEN) --library=$(vapiprefix) --girdir=$(srcdir)/src \
11- $<
12+ $< $(vapiprefix)-custom.vala
13
14
15 CLEANFILES = $(vapi_DATA)
16
17=== added file 'bindings/vala/appindicator-0.1-custom.vala'
18--- bindings/vala/appindicator-0.1-custom.vala 1970-01-01 00:00:00 +0000
19+++ bindings/vala/appindicator-0.1-custom.vala 2011-09-23 15:49:53 +0000
20@@ -0,0 +1,31 @@
21+/*
22+ Copyright (C) 2011 Canonical, Ltd.
23+
24+ This program is free software: you can redistribute it and/or modify it
25+ under the terms of either or both of the following licenses:
26+
27+ 1) the GNU Lesser General Public License version 3, as published by the
28+ Free Software Foundation; and/or
29+ 2) the GNU Lesser General Public License version 2.1, as published by
30+ the Free Software Foundation.
31+
32+ This program is distributed in the hope that it will be useful, but
33+ WITHOUT ANY WARRANTY; without even the implied warranties of
34+ MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR
35+ PURPOSE. See the applicable version of the GNU Lesser General Public
36+ License for more details.
37+
38+ You should have received a copy of both the GNU Lesser General Public
39+ License version 3 and version 2.1 along with this program. If not, see
40+ <http://www.gnu.org/licenses/>
41+
42+ Authored by Michal Hruby <michal.hruby@canonical.com>
43+*/
44+
45+namespace AppIndicator {
46+ [CCode (type_check_function = "IS_APP_INDICATOR")]
47+ public class Indicator : GLib.Object {
48+ }
49+}
50+
51+// vim:et:ai:cindent:ts=2 sts=2 sw=2:
52
53=== modified file 'bindings/vala/examples/indicator-example.vala'
54--- bindings/vala/examples/indicator-example.vala 2011-07-20 01:20:54 +0000
55+++ bindings/vala/examples/indicator-example.vala 2011-09-23 15:49:53 +0000
56@@ -34,6 +34,7 @@
57
58 var indicator = new Indicator(win.title, "indicator-messages",
59 IndicatorCategory.APPLICATION_STATUS);
60+ if (!(indicator is Indicator)) return -1;
61
62 indicator.set_status(IndicatorStatus.ACTIVE);
63 indicator.set_attention_icon("indicator-messages-new");
64
65=== modified file 'configure.ac'
66--- configure.ac 2011-08-11 16:58:08 +0000
67+++ configure.ac 2011-09-23 15:49:53 +0000
68@@ -97,7 +97,7 @@
69 # Vala Compiler support
70 ###########################
71
72-AM_PROG_VALAC([0.11.0])
73+AM_PROG_VALAC([0.14.0])
74 AM_CONDITIONAL(HAVE_VALAC, [test "x$VALAC" != "x"])
75
76 ###########################

Subscribers

People subscribed via source and target branches