Code review comment for lp:~mhaulo/mixxx/allow-playlist-and-crate-renaming

Revision history for this message
Mika Haulo (mhaulo) wrote :

> Preventing whitespace-only names is a problem. If do not mind go ahead and
> commit some fixes.

I uploaded the changes to this branch:
https://code.launchpad.net/~mhaulo/mixxx/validate_playlist_and_crate_creation

> In regards to merging, I vote for Tobias merging it into his branch. Tobias:
> if you think the code is good, I'd just merge it now and it'll be better
> scrutinized when the traktor branch is merged. Keeping branches merge-able
> with moving targets is a pita.

I'm not completely aware of your future plans about this playlist&traktor thing, but if it helps, I can create a patch directly against the branch Bill mentioned above (or whatever branch you prefer, I just need a url), including the stuff in this merge request.

« Back to merge proposal