Code review comment for lp:~mhaulo/mixxx/allow-playlist-and-crate-renaming

Revision history for this message
William Good (bkgood) wrote :

Okay, I thought this was due to some problem arising from design -- like the name was the pkey, and allowing the user to name two playlists the same thing would result in a database error. Using an auto-generated primary key is good database design as far as I've been taught.

As much as the power user in me thinks I should be able to name two playlists the same thing, the usability issues trump my desires.

In regards to merging, I vote for Tobias merging it into his branch. Tobias: if you think the code is good, I'd just merge it now and it'll be better scrutinized when the traktor branch is merged. Keeping branches merge-able with moving targets is a pita.

review: Abstain

« Back to merge proposal