Merge lp:~mhall119/summit/preserve-required into lp:summit

Proposed by Chris Johnston
Status: Superseded
Proposed branch: lp:~mhall119/summit/preserve-required
Merge into: lp:summit
Diff against target: 50 lines (+7/-7)
3 files modified
summit/schedule/models/meetingmodel.py (+5/-4)
summit/schedule/tests/tests.py (+1/-2)
summit/schedule/views.py (+1/-1)
To merge this branch: bzr merge lp:~mhall119/summit/preserve-required
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+150705@code.launchpad.net

This proposal has been superseded by a proposal from 2013-02-27.

Commit message

Keeps required participants required.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

Conflicts need to be fixed please.

review: Needs Fixing
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve
Revision history for this message
Tarmac WebDev (tarmac-webdev) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Chris Johnston (cjohnston) :
review: Approve
Revision history for this message
Tarmac WebDev (tarmac-webdev) wrote :

Attempt to merge into lp:summit failed due to conflicts:

text conflict in summit/schedule/tests/tests.py
text conflict in summit/schedule/views.py

490. By Michael Hall

[r=daker] Adds a javascript refresh to the youtube placeholder image to continue checking for a video url

491. By Chris Johnston

[r=mhall119] Separate tests into different files

492. By Michael Hall

Once again, merge from trunk and fix conflicts

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/models/meetingmodel.py'
2--- summit/schedule/models/meetingmodel.py 2013-02-26 20:00:45 +0000
3+++ summit/schedule/models/meetingmodel.py 2013-02-27 14:57:18 +0000
4@@ -497,10 +497,11 @@
5 )[0]
6
7 participant.from_launchpad = True
8- if required:
9- participant.participation = 'INTERESTED'
10- else:
11- participant.participation = 'ATTENDING'
12+ if not participant.participation == 'REQUIRED':
13+ if required:
14+ participant.participation = 'INTERESTED'
15+ else:
16+ participant.participation = 'ATTENDING'
17 participant.save()
18 except ObjectDoesNotExist:
19 pass
20
21=== modified file 'summit/schedule/tests/tests.py'
22--- summit/schedule/tests/tests.py 2013-02-27 03:18:38 +0000
23+++ summit/schedule/tests/tests.py 2013-02-27 14:57:18 +0000
24@@ -3385,7 +3385,7 @@
25 now = datetime.datetime.now()
26 week = datetime.timedelta(days=7)
27 meeting = factory.make_one(Meeting, summit=self.summit, name='test-name', title='Test Title', requires_dial_in=False, private=True)
28- user = factory.make_one(User, username='testuser', first_name='Test', last_name='User', is_active=True)
29+ user = factory.make_one(User, username='testuser', first_name='Test', last_name='User', is_active=True, is_superuser=False)
30 user.set_password('password')
31 user.save()
32 attendee = factory.make_one(Attendee, summit=self.summit, user=user, start_utc=now, end_utc=now+week)
33@@ -3414,4 +3414,3 @@
34 response = self.client.get(reverse('summit.schedule.views.search', args=[self.summit.name]), {'q': 'test'})
35 self.assertContains(response, self.form_html, 1)
36 self.assertContains(response, '<a href="%s">Test Title</a>' % meeting.get_meeting_page_url(), 1)
37-
38
39=== modified file 'summit/schedule/views.py'
40--- summit/schedule/views.py 2013-02-27 03:18:38 +0000
41+++ summit/schedule/views.py 2013-02-27 14:57:18 +0000
42@@ -92,7 +92,7 @@
43 for m in matches:
44 if not m.private or m.can_view_pm(attendee):
45 meetings.append(m)
46-
47+
48 context = {
49 'summit': summit,
50 'query': query,

Subscribers

People subscribed via source and target branches