Merge lp:~mhall119/summit/order-users-by-username into lp:summit

Proposed by Michael Hall
Status: Merged
Approved by: Chris Johnston
Approved revision: 278
Merged at revision: 276
Proposed branch: lp:~mhall119/summit/order-users-by-username
Merge into: lp:summit
Diff against target: 49 lines (+16/-1)
3 files modified
summit/schedule/admin/summitadmin.py (+1/-0)
summit/schedule/models/summitmodel.py (+14/-0)
summit/schedule/templates/schedule/daily.html (+1/-1)
To merge this branch: bzr merge lp:~mhall119/summit/order-users-by-username
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+90345@code.launchpad.net

Commit message

A quick and dirty monkey patching to give Users a sane order, added users real name in addition to their launchpad id, on meeting page also added real name in addition to launchpad id for participants.

Description of the change

A quick and dirty monkey patching to give Users a sane order, especially when used as a ForeignKey in the admin

To post a comment you must log in.
277. By Michael Hall

Add easier way of adding/removing managers and schedulers from a summit

278. By Michael Hall

Include first and last name in user display where available

Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/admin/summitadmin.py'
2--- summit/schedule/admin/summitadmin.py 2012-01-23 01:18:55 +0000
3+++ summit/schedule/admin/summitadmin.py 2012-01-27 02:07:25 +0000
4@@ -75,6 +75,7 @@
5 search_fields = ('name', 'title', 'location')
6
7 inlines = (TrackInline, TopicInline, SprintInline)
8+ filter_horizontal = ('schedulers', 'managers')
9
10 admin.site.register(Summit, SummitAdmin)
11
12
13=== modified file 'summit/schedule/models/summitmodel.py'
14--- summit/schedule/models/summitmodel.py 2012-01-24 19:07:39 +0000
15+++ summit/schedule/models/summitmodel.py 2012-01-27 02:07:25 +0000
16@@ -40,6 +40,20 @@
17 'SummitSprint',
18 )
19
20+#Monkey patch for better use in the admin
21+User._meta.ordering = ['username']
22+def unicode_user(user):
23+ display = []
24+ if user.first_name:
25+ display.append(user.first_name)
26+ if user.last_name:
27+ display.append(user.last_name)
28+ if len(display) == 0:
29+ return user.username
30+ else:
31+ return user.username + ' (' +' '.join(display) + ')'
32+User.__unicode__ = unicode_user
33+
34 class SummitManager(models.Manager):
35
36 def next(self):
37
38=== modified file 'summit/schedule/templates/schedule/daily.html'
39--- summit/schedule/templates/schedule/daily.html 2012-01-24 05:06:04 +0000
40+++ summit/schedule/templates/schedule/daily.html 2012-01-27 02:07:25 +0000
41@@ -125,7 +125,7 @@
42 <img class="icon" src="/media/img/required.png" title="required" alt="(required)">
43 {% else %}
44 <img class="icon" src="/media/img/attending.png">
45- {% endif %}{{ participant.attendee.user.username }}</div>
46+ {% endif %}{{ participant.attendee.user }}</div>
47 {% endfor %}</div>
48 {% endif %}
49 {% if agenda.meeting.tracks.count > 0 %}

Subscribers

People subscribed via source and target branches