Merge lp:~mhall119/summit/meeting-reverse-lookup-fix into lp:summit

Proposed by Michael Hall
Status: Merged
Approved by: Chris Johnston
Approved revision: 278
Merged at revision: 277
Proposed branch: lp:~mhall119/summit/meeting-reverse-lookup-fix
Merge into: lp:summit
Diff against target: 52 lines (+7/-7)
2 files modified
summit/schedule/templates/schedule/meeting.html (+6/-6)
summit/schedule/templates/schedule/past_summit.html (+1/-1)
To merge this branch: bzr merge lp:~mhall119/summit/meeting-reverse-lookup-fix
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+90442@code.launchpad.net

Commit message

Fixes reverse lookup errors on meetings with no name and past summits page

Description of the change

Fixes reverse lookup errors on meetings with no name and past summits page

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/templates/schedule/meeting.html'
2--- summit/schedule/templates/schedule/meeting.html 2012-01-25 13:47:02 +0000
3+++ summit/schedule/templates/schedule/meeting.html 2012-01-27 14:41:30 +0000
4@@ -13,7 +13,7 @@
5 {% if meeting.description %}
6 <meta property="og:description" content="{{ meeting.description|linebreaks|striptags }}" />
7 {% endif %}
8-<meta property="og:url" content="http://summit.ubuntu.com{% url summit.schedule.views.meeting meeting.summit.name, meeting.id, meeting.name %}" />
9+<meta property="og:url" content="http://summit.ubuntu.com{% url summit.schedule.views.meeting meeting.summit.name, meeting.id, meeting.name|default:'-' %}" />
10 <meta property="og:image" content="http://summit.ubuntu.com/media/images/cof_orange_hex1.png" />
11 <meta property="og:site_name" content="The Summit Scheduler" />
12 <meta property="og:type" content="article" />
13@@ -24,21 +24,21 @@
14 {% block sub_nav_links %}
15 {% if meeting.private %}
16 {% if meeting.private_key and meeting.private_key != '' %}
17- <a class="sub-nav-item" href="{% url summit.schedule.views.private_meeting meeting.summit.name, meeting.private_key, meeting.name %}">Shared URL</a>
18+ <a class="sub-nav-item" href="{% url summit.schedule.views.private_meeting meeting.summit.name, meeting.private_key, meeting.name|default:'-' %}">Shared URL</a>
19 {% else %}
20- <a class="sub-nav-item" href="{% url summit.schedule.views.meeting meeting.summit.name, meeting.id, meeting.name %}+share">Share Meeting</a>
21+ <a class="sub-nav-item" href="{% url summit.schedule.views.meeting meeting.summit.name, meeting.id, meeting.name|default:'-' %}+share">Share Meeting</a>
22 {% endif %}
23- <a class="sub-nav-item" href="{% url summit.schedule.views.edit_private summit.name, meeting.id, meeting.name %}">Edit Meeting</a>
24+ <a class="sub-nav-item" href="{% url summit.schedule.views.edit_private summit.name, meeting.id, meeting.name|default:'-' %}">Edit Meeting</a>
25 {% endif %}
26 {% if user_is_attending %}
27 {% if user_is_participating %}
28- <a class="sub-nav-item" href="{% url summit.schedule.views.unregister meeting.summit.name, meeting.id, meeting.name %}">Skip this meeting</a>
29+ <a class="sub-nav-item" href="{% url summit.schedule.views.unregister meeting.summit.name, meeting.id, meeting.name|default:'-' %}">Skip this meeting</a>
30 {% endif %}
31 {% else %}
32 {% if meeting.spec_url %}
33 <a class="sub-nav-item" href="{{ meeting.spec_url }}/+subscribe">Subscribe to Blueprint</a>
34 {% endif %}
35- <a class="sub-nav-item" href="{% url summit.schedule.views.register meeting.summit.name, meeting.id, meeting.name %}">Attend this meeting</a>
36+ <a class="sub-nav-item" href="{% url summit.schedule.views.register meeting.summit.name, meeting.id, meeting.name|default:'-' %}">Attend this meeting</a>
37 {% endif %}
38 {% endblock %}
39
40
41=== modified file 'summit/schedule/templates/schedule/past_summit.html'
42--- summit/schedule/templates/schedule/past_summit.html 2012-01-23 01:18:55 +0000
43+++ summit/schedule/templates/schedule/past_summit.html 2012-01-27 14:41:30 +0000
44@@ -4,7 +4,7 @@
45 {% block page_name %}Previous Summits{%endblock %}
46
47 {% block sub_nav_links %}
48- <a class="sub-nav-item" href="{% url summit.common.views.summit next_summit.name %}">Current Summit</a>
49+ <a class="sub-nav-item" href="{% url summit.schedule.views.summit next_summit.name %}">Current Summit</a>
50 {% endblock %}
51
52 {% block content %}

Subscribers

People subscribed via source and target branches