Merge lp:~mhall119/summit/meeting-emblems into lp:summit

Proposed by Michael Hall
Status: Merged
Approved by: Chris Johnston
Approved revision: 456
Merged at revision: 456
Proposed branch: lp:~mhall119/summit/meeting-emblems
Merge into: lp:summit
Diff against target: 125 lines (+44/-1)
5 files modified
summit/media/css/schedule.css (+3/-1)
summit/media/css/site.css (+15/-0)
summit/schedule/models/meetingmodel.py (+18/-0)
summit/schedule/render.py (+3/-0)
summit/schedule/templates/schedule/daily.html (+5/-0)
To merge this branch: bzr merge lp:~mhall119/summit/meeting-emblems
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+128821@code.launchpad.net

Commit message

Adds emblems to the top-right corner of a meeting in both the list and wide displays.

Description of the change

Adds emblems to the top-right corner of a meeting in both the list and wide displays. Emblems are used for:
roundtable
workshop
presentation
panel
bof

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/media/css/schedule.css'
2--- summit/media/css/schedule.css 2012-05-25 14:57:02 +0000
3+++ summit/media/css/schedule.css 2012-10-09 21:03:20 +0000
4@@ -131,7 +131,9 @@
5 div.slot, div.meeting {
6 display: block;
7
8- padding: 4px;
9+ padding: 1px;
10+ padding-top: 6px;
11+ padding-right: 6px;
12 border: 1px;
13 overflow: hidden;
14
15
16=== modified file 'summit/media/css/site.css'
17--- summit/media/css/site.css 2012-04-30 16:48:43 +0000
18+++ summit/media/css/site.css 2012-10-09 21:03:20 +0000
19@@ -50,6 +50,21 @@
20 white-space: pre-wrap;
21 }
22
23+div.meeting {
24+ position: relative;
25+}
26+
27+div.meeting .meeting_emblem {
28+ position: absolute;
29+ right: 1px;
30+ top: 1px;
31+ z-index: 10 !important;
32+}
33+
34+div.unscheduled div.meeting .meeting_emblem {
35+ display: none;
36+}
37+
38 div.agenda-details ul {
39 margin-bottom: 0;
40 }
41
42=== added file 'summit/media/img/meeting_emblem_bof.png'
43Binary files summit/media/img/meeting_emblem_bof.png 1970-01-01 00:00:00 +0000 and summit/media/img/meeting_emblem_bof.png 2012-10-09 21:03:20 +0000 differ
44=== added file 'summit/media/img/meeting_emblem_discussion.png'
45Binary files summit/media/img/meeting_emblem_discussion.png 1970-01-01 00:00:00 +0000 and summit/media/img/meeting_emblem_discussion.png 2012-10-09 21:03:20 +0000 differ
46=== added file 'summit/media/img/meeting_emblem_panel.png'
47Binary files summit/media/img/meeting_emblem_panel.png 1970-01-01 00:00:00 +0000 and summit/media/img/meeting_emblem_panel.png 2012-10-09 21:03:20 +0000 differ
48=== added file 'summit/media/img/meeting_emblem_presentation.png'
49Binary files summit/media/img/meeting_emblem_presentation.png 1970-01-01 00:00:00 +0000 and summit/media/img/meeting_emblem_presentation.png 2012-10-09 21:03:20 +0000 differ
50=== added file 'summit/media/img/meeting_emblem_roundtable.png'
51Binary files summit/media/img/meeting_emblem_roundtable.png 1970-01-01 00:00:00 +0000 and summit/media/img/meeting_emblem_roundtable.png 2012-10-09 21:03:20 +0000 differ
52=== added file 'summit/media/img/meeting_emblem_workshop.png'
53Binary files summit/media/img/meeting_emblem_workshop.png 1970-01-01 00:00:00 +0000 and summit/media/img/meeting_emblem_workshop.png 2012-10-09 21:03:20 +0000 differ
54=== modified file 'summit/schedule/models/meetingmodel.py'
55--- summit/schedule/models/meetingmodel.py 2012-10-09 19:01:06 +0000
56+++ summit/schedule/models/meetingmodel.py 2012-10-09 21:03:20 +0000
57@@ -56,6 +56,19 @@
58 (u'bof', u'BoF'),
59 )
60
61+ TYPE_ICONS = {
62+ u'discussion': None,
63+ u'boardroom': None,
64+ u'plenary': None,
65+ u'roundtable': 'meeting_emblem_roundtable.png',
66+ u'workshop': 'meeting_emblem_workshop.png',
67+ u'presentation': 'meeting_emblem_presentation.png',
68+ u'panel': 'meeting_emblem_panel.png',
69+ u'seminar': None,
70+ u'special': None,
71+ u'bof': 'meeting_emblem_bof.png',
72+ }
73+
74 STATUS_CHOICES = (
75 (u'NEW', u'New'),
76 (u'DISCUSSION', u'Discussion'),
77@@ -197,6 +210,11 @@
78 return reverse('summit.schedule.views.meeting', args=args)
79 meeting_page_url = property(get_meeting_page_url)
80
81+ def get_meeting_type_icon(self):
82+ if self.type in self.TYPE_ICONS:
83+ return self.TYPE_ICONS[self.type]
84+ icon = property(get_meeting_type_icon)
85+
86 def __unicode__(self):
87 if self.name:
88 return self.name
89
90=== modified file 'summit/schedule/render.py'
91--- summit/schedule/render.py 2012-09-09 21:15:17 +0000
92+++ summit/schedule/render.py 2012-10-09 21:03:20 +0000
93@@ -733,6 +733,9 @@
94 html += ' class="%s"\n' % ' '.join(classes)
95 html += ' style="%(style)s">\n'
96
97+ if meeting.icon:
98+ html += '<img src="/media/img/%s" class="meeting_emblem" title="%s" />\n' % (meeting.icon, meeting.get_type_display())
99+
100 if slot and room:
101 html += ' <span class="time">%s, %s</span>\n' % (slot.start.strftime("%A %H:%M"),
102 escape_strings(room.title))
103
104=== modified file 'summit/schedule/templates/schedule/daily.html'
105--- summit/schedule/templates/schedule/daily.html 2012-10-06 17:26:26 +0000
106+++ summit/schedule/templates/schedule/daily.html 2012-10-09 21:03:20 +0000
107@@ -51,6 +51,10 @@
108 {% for room, agenda in meetings.items %}
109 <tr style="background-color: {% ifequal agenda.meeting.type 'plenary' %}#ffffe0{% else %}{{ agenda.meeting.track_color }}{% endifequal %}; {% if agenda.meeting.private %}border: 1px; border-style: solid; border-color: #FF0000;{% endif %}">
110 <td width="75%">
111+ <div class="meeting">
112+ {% if agenda.meeting.icon %}
113+ <img src="/media/img/{{agenda.meeting.icon}}" class="meeting_emblem" title="{{agenda.meeting.get_type_display}}" />
114+ {% endif %}
115 <span onMouseOver="show_agenda_details({{agenda.id}}, {{slot.id}});" onMouseOut="hide_agenda_details({{agenda.id}}, {{slot.id}});">
116 <a href="{% url summit.schedule.views.attend_meeting agenda.meeting.summit.name, agenda.meeting.id %}">
117 {% if attendee in agenda.meeting.attendees %}
118@@ -68,6 +72,7 @@
119 {% ifnotequal forloop.counter 1 %}, {% endifnotequal %}{{ track.title }}
120 {% endfor %})</span>
121 {% endif %}
122+ </div>
123 <div id="agenda-{{agenda.id}}-{{slot.id}}-details" class="agenda-details">
124 <div class="arrow"></div>
125 <div class="meeting-description">{{agenda.meeting.description}}</div>

Subscribers

People subscribed via source and target branches