Merge lp:~mhall119/summit/fixes-661430 into lp:summit

Proposed by Michael Hall
Status: Merged
Merged at revision: 47
Proposed branch: lp:~mhall119/summit/fixes-661430
Merge into: lp:summit
Prerequisite: lp:~cjohnston/summit/661430
Diff against target: 112 lines (+29/-12)
3 files modified
summit/schedule/render.py (+20/-11)
summit/schedule/templates/schedule/schedule_list.html (+1/-1)
summit/schedule/views.py (+8/-0)
To merge this branch: bzr merge lp:~mhall119/summit/fixes-661430
Reviewer Review Type Date Requested Status
Dave Walker (community) Approve
Review via email: mp+38625@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dave Walker (davewalker) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/render.py'
2--- summit/schedule/render.py 2010-10-13 18:32:06 +0000
3+++ summit/schedule/render.py 2010-10-16 16:41:20 +0000
4@@ -288,9 +288,15 @@
5 heading += '<a href="%s">' % escape(room.icecast_url)
6 if room.track:
7 heading += '%s<br/>' % escape(room.track)
8- heading += '<span class="roomname">%s</span>' % escape(room.title)
9+ if self.edit:
10+ heading += '<span class="roomname">%s (%s)</span>' % (escape(room.title), room.size)
11+ else:
12+ heading += '<span class="roomname">%s</span>' % escape(room.title)
13 else:
14- heading += escape(room.title)
15+ if self.edit:
16+ heading += '%s (%s)' % (escape(room.title), room.size)
17+ else:
18+ heading += escape(room.title)
19 if room.icecast_url:
20 heading += '</a>'
21 elif self.room or self.track:
22@@ -299,7 +305,10 @@
23 if room.track:
24 heading = '%s, %s<br/>' % (escape(room.track),
25 date.strftime("%a"))
26- heading += '<span class="roomname">%s</span>' % escape(room.title)
27+ if self.edit:
28+ heading += '<span class="roomname">%s (%s)</span>' % (escape(room.title), room.size)
29+ else:
30+ heading += '<span class="roomname">%s</span>' % escape(room.title)
31 else:
32 heading = '%s, %s' % (escape(room.title),
33 date.strftime("%a"))
34@@ -450,8 +459,8 @@
35 had_lunch = True
36
37 # Avoid duplicating markers
38- if slot.start not in markers:
39- markers.append(slot.start)
40+ if slot.start.strftime("%H:%M") not in markers:
41+ markers.append(slot.start.strftime("%H:%M"))
42
43 style = {
44 'top': '%dpx' % top,
45@@ -468,8 +477,8 @@
46 height = 12
47
48 # Avoid duplicating markers
49- if slot.end not in markers:
50- markers.append(slot.end )
51+ if slot.end.strftime("%H:%M") not in markers:
52+ markers.append(slot.end.strftime("%H:%M") )
53
54 style = {
55 'top': '%dpx' % top,
56@@ -537,9 +546,9 @@
57 and self.track \
58 and self.edit:
59 room_name = escape(room.title)
60- if room.size:
61- room_name += ': %d people' % room.size
62- html += ' <span class="roomsize">(%s)</span>\n' % room_name
63+ if room.size and self.edit:
64+ room_name += ' (%d)' % room.size
65+ html += ' <span class="roomsize">%s</span>\n' % room_name
66 html += '</div>\n'
67
68 return mark_safe(html)
69@@ -665,7 +674,7 @@
70 room = meeting.agenda_set.exclude(room__type__exact="closed").get().room
71 room_name = room.title
72 if room.size and self.edit:
73- room_name += ': %d people' % room.size
74+ room_name += ' (%d)' % room.size
75 html += ' <span class="room">%s</span>\n' % room_name
76 except ObjectDoesNotExist:
77 pass
78
79=== modified file 'summit/schedule/templates/schedule/schedule_list.html'
80--- summit/schedule/templates/schedule/schedule_list.html 2010-10-16 16:41:20 +0000
81+++ summit/schedule/templates/schedule/schedule_list.html 2010-10-16 16:41:20 +0000
82@@ -23,7 +23,7 @@
83 By room:
84 <ul>
85 {% for room in summit.public_rooms %}
86- {% if schedule.edit %}
87+ {% if edit %}
88 {% if room.track %}
89 <li><a href="/{{ summit.name }}/{{ room.name }}">{{ room.track.title }} - {{ room.title }}</a> ({{ room.size }})</li>
90 {% else %}
91
92=== modified file 'summit/schedule/views.py'
93--- summit/schedule/views.py 2010-10-12 21:48:32 +0000
94+++ summit/schedule/views.py 2010-10-16 16:41:20 +0000
95@@ -53,9 +53,17 @@
96
97 @summit_required
98 def summit(request, summit, attendee):
99+ edit = False
100+ if (summit.state != 'public'
101+ and 'readonly' not in request.GET) \
102+ or 'edit' in request.GET:
103+ if request.user.is_authenticated() \
104+ and request.user.has_perm('schedule.change_agenda'):
105+ edit = True
106 context = {
107 'summit': summit,
108 'attendee': attendee,
109+ 'edit': edit,
110 }
111 return render_to_response("schedule/summit.html", context,
112 context_instance=RequestContext(request))

Subscribers

People subscribed via source and target branches