Merge lp:~mhall119/summit/fix-old-icals into lp:summit

Proposed by Michael Hall
Status: Merged
Approved by: Chris Johnston
Approved revision: 341
Merged at revision: 341
Proposed branch: lp:~mhall119/summit/fix-old-icals
Merge into: lp:summit
Diff against target: 26 lines (+4/-1)
2 files modified
summit/schedule/models/meetingmodel.py (+3/-0)
summit/schedule/render.py (+1/-1)
To merge this branch: bzr merge lp:~mhall119/summit/fix-old-icals
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+101763@code.launchpad.net

Commit message

Fixes ical generation for old summits

Description of the change

Old summits have a null value for meeting description, which is converted to a python None type. So even though the 'description' attribute existed, it's value was None, thus resulting in an exception being thrown in the ical generation when it tries to call .replace() on that None value

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/models/meetingmodel.py'
2--- summit/schedule/models/meetingmodel.py 2012-04-11 15:58:35 +0000
3+++ summit/schedule/models/meetingmodel.py 2012-04-12 15:50:27 +0000
4@@ -128,6 +128,9 @@
5 super(Meeting, self).save()
6 self.update_slug()
7
8+ def get_decription(self):
9+ return self.description or ''
10+
11 def share(self):
12 if not self.pk or not self.private:
13 return
14
15=== modified file 'summit/schedule/render.py'
16--- summit/schedule/render.py 2012-04-11 15:58:35 +0000
17+++ summit/schedule/render.py 2012-04-12 15:50:27 +0000
18@@ -1026,7 +1026,7 @@
19 END:VEVENT
20 ''' % {'id':meeting.id, 'dtstart':dtstart, 'dtend':dtend, 'category':categories,
21 'eventname':meeting.title, 'eventplace': room.title, 'type': meeting.type,
22- 'roomname':room.name, 'description': getattr(meeting, 'description', '').replace('\r', '').replace('\n', '\N'),
23+ 'roomname':room.name, 'description': meeting.get_decription().replace('\r', '').replace('\n', '\N'),
24 'meeting_url':meeting.meeting_page_url,
25 'base_url':getattr(settings, 'SITE_ROOT', 'http://summit.ubuntu.com')}
26 ical += 'END:VCALENDAR'

Subscribers

People subscribed via source and target branches