Merge lp:~mhall119/loco-team-portal/hashtag-feed-duplicate-improvements into lp:loco-team-portal

Proposed by Michael Hall
Status: Merged
Merged at revision: 234
Proposed branch: lp:~mhall119/loco-team-portal/hashtag-feed-duplicate-improvements
Merge into: lp:loco-team-portal
Diff against target: 26 lines (+7/-2)
1 file modified
loco_directory/media/js/twidenash.js (+7/-2)
To merge this branch: bzr merge lp:~mhall119/loco-team-portal/hashtag-feed-duplicate-improvements
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email: mp+32826@code.launchpad.net

Description of the change

More intelligent duplicate detection

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'loco_directory/media/js/twidenash.js'
--- loco_directory/media/js/twidenash.js 2010-08-15 20:55:48 +0000
+++ loco_directory/media/js/twidenash.js 2010-08-17 00:16:42 +0000
@@ -48,7 +48,12 @@
48 for (var i=0; i<data.results.length; i++) {48 for (var i=0; i<data.results.length; i++) {
49 var dupe = false;49 var dupe = false;
50 for (var j=0; j<twidenash.items.length; j++) {50 for (var j=0; j<twidenash.items.length; j++) {
51 if (data.results[i].text == twidenash.items[j].text) {51 // Strip characters that may be specific to networks
52 var comp1 = data.results[i].text.replace(/[♺\!\#\@]/g, '');
53 var comp2 = twidenash.items[j].text.replace(/[♺\!\#\@]/g, '');
54 var compdate = Date.parse(data.results[i].created_at);
55 var datediff = Math.abs(Date.parse(data.results[i].created_at) - twidenash.items[j].dt)
56 if (comp1 == comp2 && datediff < 120000) {
52 dupe = true;57 dupe = true;
53 break;58 break;
54 }59 }
@@ -74,7 +79,7 @@
74 nick.className = 'nick';79 nick.className = 'nick';
75 nick.appendChild(document.createTextNode(twidenash.items[i].user + 80 nick.appendChild(document.createTextNode(twidenash.items[i].user +
76 ": "));81 ": "));
77 var exp = /(\b(https?|ftp|file):\/\/[-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|])/i;82 var exp = /(\b(https?|ftp|file):\/\/[-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|])/gi;
78 span.innerHTML = twidenash.items[i].text.replace(exp,"<a href='$1' target='_blank'>$1</a>");83 span.innerHTML = twidenash.items[i].text.replace(exp,"<a href='$1' target='_blank'>$1</a>");
79 li.appendChild(img);84 li.appendChild(img);
80 li.appendChild(nick);85 li.appendChild(nick);

Subscribers

People subscribed via source and target branches