Merge lp:~mhall119/gwibber/fixes-658554 into lp:gwibber
Proposed by
Michael Hall
Status: | Rejected | ||||||||
---|---|---|---|---|---|---|---|---|---|
Rejected by: | Robert Bruce Park | ||||||||
Proposed branch: | lp:~mhall119/gwibber/fixes-658554 | ||||||||
Merge into: | lp:gwibber | ||||||||
Diff against target: |
12 lines (+2/-0) 1 file modified
gwibber/microblog/network.py (+2/-0) |
||||||||
To merge this branch: | bzr merge lp:~mhall119/gwibber/fixes-658554 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Bruce Park | Disapprove | ||
gwibber-committers | Pending | ||
Review via email: mp+38861@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 903. By Jay Deiman
-
Applied patch from Jay Deiman, makes Gwibber run over SOCKS4/5 proxy
Thanks for taking the time to submit this patch, unfortunately Gwibber has gone through extensive changes recently and your patch no longer applies to the latest codebase.
Fortunately, the bug you were attempting to fix is no longer present in the current codebase. The gwibber-service backend has been radically overhauled, and renamed to friends-service. The new friends-service is using libsoup, which allows us to honor the GNOME proxy settings transparently.
Please try out the latest Gwibber, I think you'll be quite pleased with what we've accomplished.