Code review comment for lp:~mhall119/django-openid-auth/strict-username-requirements

Revision history for this message
James Henstridge (jamesh) wrote :

Looks good. In test_strict_username_no_nickname, I'd leave out the nickname from the SReg response entirely though, since that is what you'd see from a provider that doesn't support nicknames.

review: Approve

« Back to merge proposal