Merge lp:~mhall119/click-reviewers-tools/snap-package into lp:click-reviewers-tools

Proposed by Michael Hall on 2017-04-11
Status: Needs review
Proposed branch: lp:~mhall119/click-reviewers-tools/snap-package
Merge into: lp:click-reviewers-tools
Diff against target: 33 lines (+28/-0)
1 file modified
snap/snapcraft.yaml (+28/-0)
To merge this branch: bzr merge lp:~mhall119/click-reviewers-tools/snap-package
Reviewer Review Type Date Requested Status
Jamie Strandboge Disapprove on 2017-04-11
Sergio Schvezov 2017-04-11 Needs Fixing on 2017-04-11
Review via email:

Description of the change

Adds snapcraft.yaml which will produce a classic-confinement snap for these review tools

To post a comment you must log in.
Sergio Schvezov (sergiusens) wrote :

If you ever want this to work on trusty or future versions of Ubuntu you will need to build your own python for which snapcraft will setup the correct program loaders. Look at the snapcraft.yaml for snapcraft or conjure-up for more information.

review: Needs Fixing
Michael Hall (mhall119) wrote :

Why won't this use the python3 bundled in the snap on those systems?

Jamie Strandboge (jdstrand) wrote :

Thanks for this! Note that there is already a 'review-tools' snap in the store and it is being worked on under a separate project name:

It is under 'git' and aims to work with strict confinement since running something on arbitrary input like a squashfs could really benefit from confinement (aka, we want the store to use this snap and benefit from confinement).

That snap (sudo snap install --edge) is non-functional though due to recent changes to the preload part. Help is appreciated if you are interested:

Disapproving not because snapping the review tools isn't desired, but because this is the wrong project/branch.

review: Disapprove
Sergio Schvezov (sergiusens) wrote :

To answer Michael for completeness, it will use the python bundled in the snap, but using a python from a stage-packages entry (in the plugin) will use the wrong program loader and be compiled with the wrong library flags making it dlopen things from the host system essentially and potentially causing crashes on systems with different glibc versions.

Unmerged revisions

870. By Michael Hall on 2017-04-11

Add snapcraft.yaml to build snap-reviewers-tools with snap-review command aliased

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'snap'
2=== added file 'snap/snapcraft.yaml'
3--- snap/snapcraft.yaml 1970-01-01 00:00:00 +0000
4+++ snap/snapcraft.yaml 2017-04-11 19:24:20 +0000
5@@ -0,0 +1,28 @@
6+name: snap-reviewers-tools
7+version: '0.47'
8+summary: Tools to review Snap packages
9+description: |
10+ These scripts can be used to review snap packages both manually and in a
11+ programmatic fashion.
13+grade: stable
14+confinement: classic
17+ snap-review:
18+ command: bin/click-review
19+ plugs: []
20+ aliases: [snap-review]
23+ click-reviewers-tools:
24+ plugin: python
25+ python-version: python3
26+ source: .
27+ stage-packages:
28+ - python3-lxml
29+ - python3-magic
30+ - python3-simplejson
31+ - python3-xdg
32+ - python3-yaml
33+ - squashfs-tools


People subscribed via source and target branches