Merge lp:~mgorven/ibid/regex-factoids-397725 into lp:~ibid-core/ibid/old-trunk-pack-0.92

[Michael Gorven]

[Michael Gorven (mgorven)]

This isn't actually ready to go in, but I'd like comments on the approach. The
only thing which isn't currently handled is using the bot's names in the
regexes.

[Stefano Rivera (stefanor)]

Not looking bad:
* You should use re.I|re.DOTALL, as some sources produce multi-line input
* I'd {pre,suf}fix r'\b' to the matches
* Some responses just don't make sense:
Query: who created you?
Response: hithere
^ Firstly, that's an invalid response, second I read it as "hit here"

Would you like a pile of clueless user logs?

[Stefano Rivera (stefanor)]

Query: bad bot
Response: sorry, baas

I'm not happy with having "sorry baas" in there, too contentious.

Query: yo there
Response: buongiorno

"buon giorno" is two words. In fact all the two-word contractions should be expanded for the response and ' ' replaced with r'\s*' in the regex.

Other oddities:

Query: morning
Response: hey
Query: afternoon
Response: Excuse me?
Query: 'day
Response: Sorry...
Query: g'day
Response: *blink*
Query: goodday
Response: hello

Query: you rock
Response: stefanor: thankyou!
Query: you are so cool
INFO:plugins.factoid:Creating factoid 1 with name 'you' by 1
INFO:plugins.factoid:Added value 'are so cool' to factoid 1 (you) by None/1 (stefanor)
Response: Done
Response: I already know stuff about you
Query: you're so cool
Response: *blink*

review: Needs Fixing

[Stefano Rivera (stefanor)]

> Query: morning
> Response: hey

Query: evening
Response: Huh?

Query: how goes?
Response: Huh?
Query: how's life?
Response: *blink*
Query: how do you do?
INFO:plugins.factoid:Creating factoid 2 with name 'how' by 1
INFO:plugins.factoid:Added value 'do you do?' to factoid 2 (how) by None/1 (stefanor)
Response: Alrighty
Query: how are you?
Response: I already know stuff about how

Obviously you don't have to fix *all* of these :)

[Stefano Rivera (stefanor)]

Some of the things this tries to do (such as "you are so cool", which I've seen in the wild quite a bit) get caught by normal factoid.

See my review on the previous proposal

review: Needs Fixing

[Stefano Rivera (stefanor)]

Another problem:
12:26 < tumbleweed> tibid: thanks
12:26 < tibid> tumbleweed: tumbleweed: np

Unmerged revisions

721. By Michael Gorven on 2009-07-18

Add some greetings and remove inappropriate response.

720. By Michael Gorven on 2009-07-15

Remove $nick since it doesn't work.

719. By Michael Gorven on 2009-07-15

Use Unicode strings.

718. By Michael Gorven on 2009-07-15

Anchor regexes at word boundaries.

717. By Michael Gorven on 2009-07-15

Make regex case insensitive and multiline.

716. By Michael Gorven on 2009-07-12

Rename to StaticFactoid.

715. By Michael Gorven on 2009-07-12

Allow regex factoids to be overridden or added individually.

714. By Michael Gorven on 2009-07-12

Move factoid interpolation to separate function and use in regex processor.

713. By Michael Gorven on 2009-07-12

Add simple statically configured regex factoid processor.

=== modified file 'ibid/plugins/factoid.py'
--- ibid/plugins/factoid.py	2009-07-12 12:43:30 +0000
+++ ibid/plugins/factoid.py	2009-07-18 10:36:21 +0000
@@ -342,6 +342,23 @@
         else:
             event.addresponse(u"I couldn't find anything with that name")
 
+def _interpolate(message, event):
+    message = message.replace('$who', event.sender['nick'])
+    message = message.replace('$channel', event.channel)
+    utcnow = time()
+    now = localtime(utcnow)
+    message = message.replace('$year', str(now[0]))
+    message = message.replace('$month', str(now[1]))
+    message = message.replace('$day', str(now[2]))
+    message = message.replace('$hour', str(now[3]))
+    message = message.replace('$minute', str(now[4]))
+    message = message.replace('$second', str(now[5]))
+    message = message.replace('$date', format_date(utcnow, 'date'))
+    message = message.replace('$time', format_date(utcnow, 'time'))
+    message = message.replace('$dow', strftime('%A', now))
+    message = message.replace('$unixtime', str(utcnow))
+    return message
+
 class Get(Processor, RPC):
     u"""<factoid> [( #<number> | /<pattern>/[r] )]"""
     feature = 'factoids'
@@ -382,20 +399,7 @@
                 reply = reply.replace('$%s' % position, capture)
                 position = position + 1
 
-            reply = reply.replace('$who', event.sender['nick'])
-            reply = reply.replace('$channel', event.channel)
-            utcnow = time()
-            now = localtime(utcnow)
-            reply = reply.replace('$year', str(now[0]))
-            reply = reply.replace('$month', str(now[1]))
-            reply = reply.replace('$day', str(now[2]))
-            reply = reply.replace('$hour', str(now[3]))
-            reply = reply.replace('$minute', str(now[4]))
-            reply = reply.replace('$second', str(now[5]))
-            reply = reply.replace('$date', format_date(utcnow, 'date'))
-            reply = reply.replace('$time', format_date(utcnow, 'time'))
-            reply = reply.replace('$dow', strftime('%A', now))
-            reply = reply.replace('$unixtime', str(utcnow))
+            reply = _interpolate(reply, event)
 
             (reply, count) = action_re.subn('', reply)
             if count:
@@ -415,7 +419,7 @@
     interrogatives = Option('interrogatives', 'Question words to strip', default_interrogatives)
     verbs = Option('verbs', 'Verbs that split name from value', default_verbs)
 
-    priority = 910
+    priority = 800
     permission = u'factoid'
     
     def setup(self):
@@ -605,4 +609,45 @@
 
             event.addresponse(True)
 
+greetings = (u'lo', u'ello', u'hello', u'hi', u'hithere', u'howdy', u'hey', u'heya', u'hiya', u'hola', u'salut', u'bonjour', u'sup', u'wussup', u'hoezit', u'wotcha', u'wotcher', u'yo', u'word', u'goodday', u'wasup', u'wassup', u'howzit', u'howsit', u'buongiorno', u'hoelykit', u'hoegaandit', u'goodmorning', u'morning', u'afternoon', u'evening')
+static_default = {
+    'greet': {
+        'matches': [r'\b(' + '|'.join(greetings) + r')\b'],
+        'responses': greetings,
+    },
+    'reward': {
+        'matches': [r'\bbot(\s+|\-)?snack\b'],
+        'responses': [u'thanks, $who', u'$who: thankyou!', u':)'],
+    },
+    'praise': {
+        'matches': [r'\bgood(\s+fuckin[\'g]?)?\s+(lad|bo(t|y)|g([ui]|r+)rl)\b', r'\byou\s+(rock|rocks|rewl|rule|are\s+so+\s+co+l)\b'],
+        'responses': [u'thanks, $who', u'$who: thankyou!', u':)'],
+    },
+    'thanks': {
+        'matches': [r'\bthank(s|\s*you)\b', r'^\s*ta\s*$', r'^\s*shot\s*$'],
+        'responses': [u'no problem, $who', u'$who: my pleasure', u'sure thing, $who', u'no worries, $who', u'$who: np', u'no probs, $who', u'$who: no problemo', u'$who: not at all'],
+    },
+    'criticism': {
+        'matches': [r'\b((kak|bad|st(u|oo)pid|dumb)(\s+fuckin[\'g]?)?\s+(bo(t|y)|g([ui]|r+)rl))|(bot(\s|\-)?s(mack|lap))\b'],
+        'responses': [u'*whimper*', u'sorry, $who :(', u':(', u'*cringe*'],
+    },
+}
+
+class StaticFactoid(Processor):
+    priority = 900
+
+    extras = Option('static', 'List of static factoids using regexes', {})
+
+    def setup(self):
+        self.factoids = static_default.copy()
+        self.factoids.update(self.extras)
+
+    @handler
+    def static(self, event):
+        for factoid in self.factoids.values():
+            for match in factoid['matches']:
+                if re.search(match, event.message['stripped'], re.I|re.DOTALL):
+                    event.addresponse(_interpolate(choice(factoid['responses']), event))
+                    return
+
 # vi: set et sta sw=4 ts=4: