Code review comment for lp:~mgorven/ibid/regex-factoids-397725

Revision history for this message
Stefano Rivera (stefanor) wrote :

Not looking bad:
* You should use re.I|re.DOTALL, as some sources produce multi-line input
* I'd {pre,suf}fix r'\b' to the matches
* Some responses just don't make sense:
Query: who created you?
Response: hithere
^ Firstly, that's an invalid response, second I read it as "hit here"

Would you like a pile of clueless user logs?

« Back to merge proposal