Code review comment for lp:~mgorven/ibid/port-numbers

Revision history for this message
marcog (marco-gallotta) wrote :

Query: port for http
Response: 80/tcp and 80/udp
Query: port 80
Response: http (TCP) and http (UDP)

Perhaps group them if the protocol is the same?

Query: port for http
Response: 80 (tcp and udp)
Query: port 80
Response: http (TCP and UDP)

The one response uses / and the other uses (), perhaps they should match. The case should also match.

Query: X11:1 port
Response: I don't know about that protocol
Query: port 6001
Response: X11:1 (TCP)

?

review: Needs Fixing

« Back to merge proposal