Code review comment for lp:~mgorven/ibid/port-numbers

Revision history for this message
Stefano Rivera (stefanor) wrote :

I'm not convinced that this needs to be cached from load time. Generating the dict on use would save memory. But that's a more general issue, not specific to this plugin.

ICMP ports?

Query: usage ports
Response: I don't know about that protocol
Query: help ports
Response: I don't know about that protocol

review: Needs Fixing

« Back to merge proposal