Code review comment for lp:~mgorven/ibid/oui

Revision history for this message
marcog (marco-gallotta) wrote :

> > That is very unexpected if the user was not trying to lookup a mac address.
> > I would require the 11:22:33 format (even disallowing 11-22-33 because
> > that looks like an expression) if the leading word (mac, ether, etc.) is
> > left out.
>
> r888. It does allow anything from 3 to 6 groups, but I think that's okay.

Getting very nitpicky, but this is a bit weird:

Query: mac 123456
Response: I don't know who that belongs to
Query: mac 1234567
Response: Excuse me?
Query: mac 12345678
Response: I don't know who that belongs to

review: Approve

« Back to merge proposal