Code review comment for lp:~mgorven/ibid/oui

Revision history for this message
Keegan Carruthers-Smith (keegan-csmith) wrote :

> Not sure if we usually implement workarounds for this, but this is failing
> because another feature in this plugin has a dependency that isn't installed.

I agree, why should everything fail just because of that? Especially since this will not be necessarily run on a debianesque machine.

> + @match(r'^(?:(?:mac|oui|ether|ether(?:net)?(?:\s*code)?)\s+)?((?:(?:[0-9a-f]
> {2}[:-]?){3}){1,2})$')
>
> You can remove the "ether|" as it's caught by the one that follows.

Agreed.

Otherwise I approve.

review: Approve

« Back to merge proposal