Code review comment for lp:~mgorse/duplicity/0.8-series

Revision history for this message
Mgorse (mgorse) wrote :

Taking into account the comment related to util.fsencode(), I think that tarinfo names need to be bytes, since they can be used to generate paths, and manifest strings also need to be bytes, since they can be read back in to generate a manifest. At the same time, I'm not sure if a __str__ function should be returning bytes, although I'm not seeing a good solution.

« Back to merge proposal