Code review comment for ~mgerdts/cloud-init:lp1746605

Revision history for this message
Scott Moser (smoser) wrote :

Mike,

I enabled unused variables warnings in pylint a few commits
back. if you rebase this you'll see the errors.

the warning looks like this:
  tests/unittests/test_datasource/test_smartos.py:1053: [W0612(unused-variable), TestSerialConcurrency.test_all_keys] Unused variable 'it'

The fix is just to name that variable '_it' rather than 'it'. Or
even just '_'.

then it wont' complain.

Easiest thing is for you to commit that and push.
as it is right nwo our tools rebase yo to trunk and run tox and then merge... and if i want to use the tools (I do) then you fixing this branch is the easiest thing.

« Back to merge proposal