Yes, that was redundant. Fixed & retested (tox + real system). Fixed in changeset:
commit 076968c6efc9759d196e604df24aa1bd1701b9be Author: Mike Gerdts <email address hidden> Date: Mon Apr 16 22:39:35 2018 -0500
smoser final feedback: redundant flush
Thanks much for the review, help, and approval.
Mike
On Mon, Apr 16, 2018 at 7:50 PM, Scott Moser <email address hidden> wrote:
> Review: Approve > > https://jenkins.ubuntu.com/server/job/cloud-init-ci/1009/console > > I approve of this branch, either fix the nit in my last comment or justify > it. > > > -- > https://code.launchpad.net/~mgerdts/cloud-init/+git/cloud- > init/+merge/343118 > You are the owner of ~mgerdts/cloud-init:lp1667735. >
« Back to merge proposal
Yes, that was redundant. Fixed & retested (tox + real system). Fixed in
changeset:
commit 076968c6efc9759 d196e604df24aa1 bd1701b9be
Author: Mike Gerdts <email address hidden>
Date: Mon Apr 16 22:39:35 2018 -0500
smoser final feedback: redundant flush
Thanks much for the review, help, and approval.
Mike
On Mon, Apr 16, 2018 at 7:50 PM, Scott Moser <email address hidden>
wrote:
> Review: Approve /jenkins. ubuntu. com/server/ job/cloud- init-ci/ 1009/console /code.launchpad .net/~mgerdts/ cloud-init/ +git/cloud- cloud-init: lp1667735.
>
> https:/
>
> I approve of this branch, either fix the nit in my last comment or justify
> it.
>
>
> --
> https:/
> init/+merge/343118
> You are the owner of ~mgerdts/
>