Code review comment for lp:~mfisch/ubuntu-desktop-accomplishments/install-on-arm

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Hey Matt, thanks for these fixes and new accom.

I am mostly fine with all these changes, here are few notes:
 * I doubt we need tests for local accomplishments. They only make sense for global ones, as they can be verified for given extra-information; the tests you have added to this branch are not going to be any helpful, using <email address hidden> does not make me get installed-on-arm trophy ;)
 * The last step in installed-on-arm descrioption ("join #ubuntu-arm and participate in community") is more like a tip then a step to me, it's not required to receive this trophy, so putting that in tips field might make a bit more sense.

Apart from that, this MP is great.

« Back to merge proposal