Merge lp:~mfisch/lightdm/lightdm-lp999718 into lp:lightdm

Proposed by Matt Fischer
Status: Merged
Merged at revision: 1506
Proposed branch: lp:~mfisch/lightdm/lightdm-lp999718
Merge into: lp:lightdm
Diff against target: 12 lines (+1/-1)
1 file modified
src/vt.c (+1/-1)
To merge this branch: bzr merge lp:~mfisch/lightdm/lightdm-lp999718
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+108668@code.launchpad.net

Description of the change

Fixes 999718 - g_open seems to require 3 arguments on some platforms/versions

Tested in a VM and validated from the logging that the code was called and also switched terminals a few times. I think if this didn't work it would be very obvious.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/vt.c'
--- src/vt.c 2012-01-31 05:25:20 +0000
+++ src/vt.c 2012-06-05 04:28:21 +0000
@@ -30,7 +30,7 @@
30{30{
31 int fd;31 int fd;
3232
33 fd = g_open ("/dev/console", O_RDONLY | O_NOCTTY);33 fd = g_open ("/dev/console", O_RDONLY | O_NOCTTY, 0);
34 if (fd < 0)34 if (fd < 0)
35 g_warning ("Error opening /dev/console: %s", strerror (errno));35 g_warning ("Error opening /dev/console: %s", strerror (errno));
36 return fd;36 return fd;

Subscribers

People subscribed via source and target branches