Code review comment for lp:~mew/juju-deployer/option-from-file

Revision history for this message
Matthew Wedgwood (mew) wrote :

Sorry, I should have thought about that a bit more thoroughly. Escaping isn't the problem, is it?

The intention of include-file and include-base64 is to provide a way to pull in values that may be built externally or have complex internal structure that would be difficult to maintain inside a JSON (or YAML) file.

In the example I mentioned above, "vhost_https_template" option from the apache2 charm is a jinja2 templated httpd.conf-style configuration hunk. It's usually hand-maintained. I could also imagine something like a crontab file being included this way, and I believe cron is particular about having a trailing newline.

« Back to merge proposal