Code review comment for lp:~mew/charm-helpers/refactor-to-core

Hi Matthew,

Thanks for doing this reorganization. Lots of work and gets the project moving.

I couldn't get 'make test' to run until I installed
python-nose
python-mock
python-testtools

Could you add those to README.test?

The temporary mapping in __ALL__ for stuff moved from charmhelpers/__init__.py is a nice touch.

A lot of the things you marked 'Deprecated: client-only' are functions that we used in testing our charms. They are actually quite nice. I'd like to see the 'Deprecation' tag removed and try to find a place to put them. If you'd like to see them in use have a look at the buildbot-master charm.

Overall I like this direction.