Merge lp:~mew/charm-helpers/no-host-magic into lp:charm-helpers
Proposed by
Matthew Wedgwood
Status: | Merged |
---|---|
Merged at revision: | 59 |
Proposed branch: | lp:~mew/charm-helpers/no-host-magic |
Merge into: | lp:charm-helpers |
Diff against target: |
190 lines (+26/-57) 2 files modified
charmhelpers/core/host.py (+7/-10) tests/core/test_host.py (+19/-47) |
To merge this branch: | bzr merge lp:~mew/charm-helpers/no-host-magic |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Review via email: mp+174038@code.launchpad.net |
Description of the change
Remove magic value interpolation from host.py. Similar functionality exists
in contrib.templating.
To post a comment you must log in.
Is host.symlink() useful at all now? I guess os.symlink() doesn't force creation and no logging.
Looks good to me.