Merge lp:~meths/openlp/testing into lp:openlp

Proposed by Jon Tibble
Status: Merged
Merged at revision: not available
Proposed branch: lp:~meths/openlp/testing
Merge into: lp:openlp
Diff against target: None lines
To merge this branch: bzr merge lp:~meths/openlp/testing
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Raoul Snyman Approve
Review via email: mp+11666@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jon Tibble (meths) wrote :

Complete theme fixing

Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve
Revision history for this message
Tim Bentley (trb143) wrote :

Approved

review: Approve
lp:~meths/openlp/testing updated
535. By Jon Tibble

For Jon
Fix themes 2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/core/ui/amendthemeform.py'
2--- openlp/core/ui/amendthemeform.py 2009-09-12 17:24:16 +0000
3+++ openlp/core/ui/amendthemeform.py 2009-09-13 14:12:38 +0000
4@@ -201,7 +201,8 @@
5 #self.theme.background_mode
6 self.theme.background_startColor = theme.background_startColor.strip()
7 #self.theme.background_type
8- self.theme.display_display = theme.display_display.strip()
9+ if theme.display_display:
10+ self.theme.display_display = theme.display_display.strip()
11 self.theme.display_horizontalAlign = \
12 theme.display_horizontalAlign.strip()
13 self.theme.display_outline = str_to_bool(theme.display_outline)
14
15=== modified file 'openlp/core/ui/thememanager.py'
16--- openlp/core/ui/thememanager.py 2009-09-13 13:24:58 +0000
17+++ openlp/core/ui/thememanager.py 2009-09-13 14:12:38 +0000
18@@ -139,9 +139,8 @@
19 def onEditTheme(self):
20 item = self.ThemeListWidget.currentItem()
21 if item is not None:
22- self.amendThemeForm.setTheme(self.getThemeData(
23- item.data(QtCore.Qt.UserRole).toString()))
24- self.amendThemeForm.loadTheme()
25+ self.amendThemeForm.loadTheme(
26+ unicode(item.data(QtCore.Qt.UserRole).toString()))
27 self.amendThemeForm.exec_()
28
29 def onDeleteTheme(self):