Merge lp:~methanal-developers/methanal/form-actions-care-about-submitting into lp:methanal

Proposed by Jonathan Jacobs
Status: Merged
Approved by: Tristan Seligmann
Approved revision: 146
Merged at revision: 145
Proposed branch: lp:~methanal-developers/methanal/form-actions-care-about-submitting
Merge into: lp:methanal
Diff against target: 50 lines (+14/-5)
1 file modified
methanal/js/Methanal/View.js (+14/-5)
To merge this branch: bzr merge lp:~methanal-developers/methanal/form-actions-care-about-submitting
Reviewer Review Type Date Requested Status
Tristan Seligmann Approve
Review via email: mp+30189@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tristan Seligmann (mithrandi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'methanal/js/Methanal/View.js'
--- methanal/js/Methanal/View.js 2010-07-14 10:13:31 +0000
+++ methanal/js/Methanal/View.js 2010-07-17 20:11:41 +0000
@@ -918,16 +918,21 @@
918918
919 self.clearError();919 self.clearError();
920 self.actions.disable();920 self.actions.disable();
921 self.freeze();
921 self.actions.throbber.start();922 self.actions.throbber.start();
922923
923 var d = self.callRemote('invoke', data);924 var d = self.callRemote('invoke', data);
924 d.addBoth(function (value) {925 d.addBoth(function (value) {
926 self.thaw();
925 self.actions.throbber.stop();927 self.actions.throbber.stop();
926 self.actions.enable();
927 return value;928 return value;
928 });929 });
929 d.addCallback(function (value) { return self.submitSuccess(value); });930 d.addCallback(function (value) {
930 d.addErrback(function (value) { return self.submitFailure(value); });931 return self.submitSuccess(value);
932 });
933 d.addErrback(function (value) {
934 return self.submitFailure(value);
935 });
931 return d;936 return d;
932 },937 },
933938
@@ -989,17 +994,21 @@
989994
990995
991 /**996 /**
992 * Callback for successful form submission.997 * Callback for successful form submission. The return value will be sent
998 * back to the server.
993 */999 */
994 function submitSuccess(self, value) {1000 function submitSuccess(self, value) {
1001 return null;
995 },1002 },
9961003
9971004
998 /**1005 /**
999 * Callback for a failure form submission.1006 * Callback for a failure form submission. The return value will be sent
1007 * back to the server.
1000 */1008 */
1001 function submitFailure(self, failure) {1009 function submitFailure(self, failure) {
1002 self.setError(failure);1010 self.setError(failure);
1011 return null;
1003 },1012 },
10041013
10051014

Subscribers

People subscribed via source and target branches