~mertkirpici/juju-lint:lp/2009536

Last commit made on 2023-03-28
Get this branch:
git clone -b lp/2009536 https://git.launchpad.net/~mertkirpici/juju-lint
Only Mert Kirpici can upload to this branch. If you are Mert Kirpici please log in for upload directions.

Branch merges

Branch information

Name:
lp/2009536
Repository:
lp:~mertkirpici/juju-lint

Recent commits

7c63022... by Mert Kirpici

tests/functional: pin juju<3

Works-on: 2007834
Signed-off-by: Mert Kırpıcı <email address hidden>

2a4082f... by Mert Kirpici

lint: check multiple subs for required ones only

Starting with this commit, juju-lint only generates an error in case of
a subordinate charm having multiple units on a given machine if:
- the subordinate charm is declared under the top level "subordinates"
  YAML object
- it does not set allow-multiple or sets it to false. this essentially
  defines the default value for the "allow-multiple" config as false.

The previous implementation did not care about the subordinate charm
being listed under the "subordinates" at all. This behavior caused a
crash when an optional subordinate is deployed multiple times on a
machine.

Works-on: 2009536
Signed-off-by: Mert Kırpıcı <email address hidden>

3313998... by Gabriel Cocenza

Added check for nova-compute ephemeral devices config

This alerts if the nova-compute config option "ephemeral-device" is set
to /dev/sdX or /dev/vgX, to prevent ephemeral devices on landing on a
root drive.

Closes-Bug: #1999263

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/436732
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Martin Kalcok <email address hidden>
Reviewed-by: Tianqi Xiao <email address hidden>

ea92314... by Gabriel Cocenza

Added check for nova-compute ephemeral devices config

This alerts if the nova-compute config option "ephemeral-device" is set
to /dev/sdX or /dev/vgX, to prevent ephemeral devices on landing on a
root drive.

Co-authored-by: Marcus Boden <email address hidden>
Closes-Bug: #1999263

07d72e1... by Mert Kirpici

Close LP #1987359

Reviewed-on: https://code.launchpad.net/~mertkirpici/juju-lint/+git/juju-lint/+merge/436319
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Gabriel Angelo Sgarbi Cocenza <email address hidden>

4c85ec6... by Mert Kirpici

lint: log rules after overrides not before

Works-on: 1987359

Signed-off-by: Mert Kırpıcı <email address hidden>

e741ba4... by Mert Kirpici

lint: add missing timeout to urlopen

Works-on: 1987359

Signed-off-by: Mert Kırpıcı <email address hidden>

30a938c... by Mert Kirpici

lint: handle timeout during urlopen

Works-on: 1987359

Signed-off-by: Mert Kırpıcı <email address hidden>

8e08ade... by Mert Kirpici

cli: parse -c carefully

While parsing the -c command line option, take care of the extra space
and the commas. Also add a unit test that checks against weird inputs.

Works-on: 1987359

Signed-off-by: Mert Kırpıcı <email address hidden>

d7316ce... by Mert Kirpici

lint: handle url exception